Extract code for embedded from mattermost-plugin-msteams plugin
#11
Conversation
There was a problem hiding this comment.
LGTM. We should remove the routing behaviour in a follow-up PR.
Golangci-lint is failing, the CI installs one version of the CI and the Makefile is installing another, unsure if this has something to do with it. Also there are some issues with test since we are making an unexpected call to GetApp on plugin load, so it seems the test-helper is failing on every test.
| closeCh := make(chan struct{}) | ||
|
|
||
| // plugin.ClientMain with options allows for reattachment. | ||
| go plugin.ClientMain( |
There was a problem hiding this comment.
Probably needs th.appClientMock.On("GetApp", p.configuration.AppClientID).Return(&clientmodels.App{}, nil).Once() around to mock the checkCredentials call when the plugin activates.
Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
I think/thought I did remove it in this PR. Do you mean remove it from the msteams-sync plugin? |
There were several pieces of logic for the routing (of the top of my mind):
|
Summary
This is an extraction of the code needed for embedding MM in MS Teams or other M365 apps from the mattermost-plugin-msteams plugin.
Tested against the
tsomrettamtest tenant, and validated that SSO and notifications are working.Ticket Link
https://mattermost.atlassian.net/browse/MM-63353