Skip to content

matplotblog May 27, 2020 typo, should be: plt.plot( time, distance, 'bo-') #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gplanansky opened this issue Dec 29, 2020 · 4 comments

Comments

@gplanansky
Copy link

first code block, line 4:
second code block, line 3:
third code block, line3:
plt.plot(distance,'bo-') should be plt.plot(time, distance, 'bo-')

I did not see a comment section at the blog itself.

@story645 story645 transferred this issue from matplotlib/matplotlib Dec 29, 2020
@story645
Copy link
Member

story645 commented Dec 29, 2020

Hi, thanks for the report. Transferred this issue to the blog repository. Would you be interested in opening a PR to fix the typos?

@gplanansky
Copy link
Author

gplanansky commented Dec 30, 2020 via email

@story645
Copy link
Member

The repo is https://github.com/matplotlib/matplotblog

If you want full instructions, they're at https://matplotlib.org/matplotblog/posts/how-to-contribute/

The pr through gui steps are:

  1. fork this repo
  2. on your fork, find the file with the typo
  3. fix it & commit the change to a new branch
  4. press the "open pull request" button
  5. select matplotblog:master as the target (arrow points towards it: matplotblog:master<-)
  6. Submit the pull request.

More info at
https://docs.github.com/en/free-pro-team@latest/desktop/contributing-and-collaborating-using-github-desktop/creating-an-issue-or-pull-request

davidevaleriani added a commit that referenced this issue Jan 5, 2021
…rface

issue #43 fix: added "time" argument to plt.plot
@davidevaleriani
Copy link
Member

This has been fixed, so closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants