Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cosmology to be specified for mock spatial calculations #71

Closed
manodeep opened this issue Aug 25, 2016 · 1 comment
Closed

Allow cosmology to be specified for mock spatial calculations #71

manodeep opened this issue Aug 25, 2016 · 1 comment

Comments

@manodeep
Copy link
Owner

For the calculations that involve converting from redshift (or cz) to co-moving distance, the conversion depends on the cosmology. Therefore, the relevant codes DDrppi_mocks and vpf_mocks should either let the user pass in the co-moving distances directly or let the user specify the cosmology. Currently, cosmology has to be implemented directly in the code itself -- in utils/cosmology_params.c under the function init_cosmology. This change will also remove the need for the globals declared/defined under utils/cosmology_params.[ch].

Both solutions should be implemented. The first one (user does the calculation) is easy: just check the flag is_comoving_distin struct config_options defined in utils/defs.h.

The second one (cosmology specified at runtime) will need a little more attention. There is no machinery at the command-line executables to handle cosmology. And I really would like to keep the python API identical to the command-line.

@manodeep
Copy link
Owner Author

manodeep commented Sep 5, 2016

is_comoving_dist is now implemented. May be in a later version, I will think about adding in the arbitrary cosmology support at the command-line level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant