Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone pattern fails for service numbers and 4 digit numbers #16

Closed
luciferreeves opened this issue Sep 23, 2022 · 0 comments · Fixed by #19
Closed

Phone pattern fails for service numbers and 4 digit numbers #16

luciferreeves opened this issue Sep 23, 2022 · 0 comments · Fixed by #19
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@luciferreeves
Copy link
Owner

luciferreeves commented Sep 23, 2022 •
edited
Loading

Phone number pattern fails to match Niue local numbers which are 4 digits-long, as well as service numbers like 911 or 18. It also does not match numbers with letters in them.
@luciferreeves luciferreeves added bug Something isn't working good first issue Good for newcomers labels Sep 23, 2022
@luciferreeves luciferreeves linked a pull request Oct 6, 2022 that will close this issue
Fixed validation for special phone numbers #19
Merged
@luciferreeves luciferreeves mentioned this issue Oct 6, 2022
Merged
luciferreeves added a commit that referenced this issue Oct 6, 2022
@luciferreeves
Fixed validation for special phone numbers (#19)
3dfdd67 
Fixes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed validation for special phone numbers luciferreeves/edify
1 participant
@luciferreeves