Refactor architecture #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
April 23, 2024 10:29
список каналов вывел дикшинэрис и оттуда импортирую в index файле.
при команде ?profile выдает профиль юзера.
…t_to_another_file # Conflicts: # src/repositories/ratingHistoryRepository.ts
…профиль. также когда нельзя было вызвать свои профиль.
# Conflicts: # src/chat/public/index.ts # src/index.ts
Aresenka
reviewed
Apr 30, 2024
src/index.ts
Outdated
| link_preview_options: {is_disabled: true}, | ||
| }); | ||
| }); | ||
| bot.command("map", (ctx: Context) => { |
There was a problem hiding this comment.
Должно быть так: bot.command("map", replyMap)
added 9 commits
May 7, 2024 18:54
Aresenka
reviewed
May 15, 2024
| link_preview_options: {is_disabled: true}, | ||
| }); | ||
| }); | ||
| function replyMap(ctx: Context) { |
There was a problem hiding this comment.
Эта функция должна быть в mapHandler
| }); | ||
| } | ||
|
|
||
| bot.command("map", replyMap); |
There was a problem hiding this comment.
bot.command("map", mapHandler);
|
|
||
| await messageFunctionMap[msg.toLowerCase().trim()](ctx); | ||
|
|
||
| switch (msg.toLowerCase().trim()) { |
There was a problem hiding this comment.
Зачем этот свич, если у нас всё прописано в messageFunctionMap?
There was a problem hiding this comment.
Почему этот класс называется src/repositories/balanceRepository/balanceRepository.ts, а внутри код для recordRatingChange?
There was a problem hiding this comment.
потому кто :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.