-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support mark-(next|previous)-like-this #1764
Conversation
double C-g - means first toggle region, secong cancel multiple-cursors spam cursors fixed
I have a problem with test running. I read an instruction from this page .qlot/bin/rove lem-tests.asd
Testing System lem-tests
✓ 0 tests completed
Summary:
All 0 tests passed. no test executed or .qlot/bin/rove tests/cursors.lisp
Unhandled ASDF/FIND-COMPONENT:MISSING-COMPONENT in thread #<SB-THREAD:THREAD tid=1070475 "main thread" RUNNING
{1003F80003}>:
Component "lem-tests/cursors" not found If someone know what is wrong, please let me know 🙏 I saw your like:) Can you help me pls @cxxxr |
lem-tests is not a package-inferred-system, so it is not possible to run tests on a file-by-file basis from rove. |
tests cover - mark prev/next like by active region - C-g double click behavior First cancel active regions in multicursors mode Second cancel multicursors - mark prev/next like in the same line - keep point in the same position regardless search direction
I think that's enough for this PR. If you see any issues in my code, feel free to leave comments :) |
Thank you for the PR. Line 90 in 34126e5
|
Oh, yes, it is a similar function. I didn't know that this function already exists in isearch module. Let's close this PR and I just keep it in my personal build. Also it will be great to add mention in Lem doc in multiple cursors description. Because when I read it I thought: "Oh, there is no my most useful function mc mode. I must implement this" |
Yeah, I'm sorry there are no documents. That's something we need to improve. |
isearch-abort - if during the isearch mode user add any fake cursros we should stay in the same place
Thank you so much! |
* feat: support mark-(next|previous)-like-this * feat: double C-g double C-g - means first toggle region, secong cancel multiple-cursors spam cursors fixed * added tests: tests cover - mark prev/next like by active region - C-g double click behavior First cancel active regions in multicursors mode Second cancel multicursors - mark prev/next like in the same line - keep point in the same position regardless search direction * removed useless lines * Search since last element (not loop) * feat: isearch-add-cursors in different directions isearch-abort - if during the isearch mode user add any fake cursros we should stay in the same place * remove extra var
There is a similar PR, but I didn't use isearch to find the next marks.
mark-(next|previous)-like-this aims to work like multiple-cursors.el This means that if there is nothing to select, it marks the next or previous line.
Handling offsets is a bit complex because we need to maintain the same starting or ending position of the region when calling mark-next or mark-prev.
Demo:

TODO: