fix: plugins are not installed when plugin-daemon is restarted and plugins are stored on s3 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35
closes langgenius/dify#14769
closes langgenius/dify#14534
I moved the exists operation from installedBucket.List to localStorage.List. This makes the exist function for S3 storage no longer called, fixing the issue without changing any existing behavior for localStorage.
Since some implementation of storage does not require to check the existence of a directory before list operation, I believe it makes more sense to run an exists function inside a list function of each implementation, instead of handling it from caller.