fix : Ensure galaxy, system, position and type available #610
Conversation
|
Looks good to me! 👍 I did try and check just now though how the official game handles this, and if I reproduce it on there I see that the fleet check call still comes with a valid response when the position is empty: 
So I'm guessing that they are defaulting the position (or any other coordinates) to "0" on the serverside, so even if the client does not pass along a value the server side call still succeeds and returns a valid response (with no planets/missions found, which is fine). I'm not sure how complicated it is to change the server side logic for this call to make it work without changing the client side JS, but either way seems like a fine solution to me to prevent the exception/hanging loader. |
|
Merging for now, as will prevent the errors-- then will potentially refactor the backend at a later point. |
Description
When using the fleet system and emptying the galaxy box for instance, if you switch from say planet to moon, it will cause an exception and forever load.
Found this while looking into exceptions via webhook.
This basically ensures all the params are there, otherwise it'll stop loading - this seems to make the most sense here as it's where the params are being prepared to post.
Type of Change:
Related Issues
Fixes #609
Checklist