Shipyard thousands separator #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2025 04:14
…thousands separator UnitViewModel was updated to proxy in Resource formatting abilities so that it may utilize number formatting easily. - Added new UnitViewModelTest - Updated unit-item.blade.php to use resource format ability applied to UnitViewModel - Updated UnitViewModel.php to proxy in Resource functionality
…thousands separator UnitViewModel was updated to proxy in Resource formatting abilities so that it may utilize number formatting easily. - Added new UnitViewModelTest - Updated unit-item.blade.php to use resource format ability applied to UnitViewModel - Updated UnitViewModel.php to proxy in Resource functionality
|
Hi @theshado40, Looks good, just tested your PR on my end and works as it should! Thank you for fixing this and also thanks for taking the time to add tests. Merging now. Welcome as an official contributor to the OGameX project 😄 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes made to OGameX and their purpose. Clearly describe what this PR does and why it is necessary.
Type of Change:
Related Issues
Link to any issues or discussions that this PR addresses:
Fixes #[issue-number]
Checklist
Before submitting this pull request, ensure all following requirements as outlined in CONTRIBUTING.md are met:
Code Standards: Code adheres to PSR-12 coding standards. Verified with Laravel Pint.
Static Analysis: Code passes PHPStan static code analysis.
Testing:
CSS & JS Build: CSS and JS assets are compiled using Laravel Mix if any changes are made to JS/CSS files.
Documentation: Documentation has been updated to reflect any changes made.
Additional Information
Add any additional context, screenshots, or explanations to help reviewers understand your PR. If this change introduces any breaking changes or significant impacts, please detail them here.