Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit with usage when need login to image registry #8225

Merged
merged 6 commits into from
May 21, 2020
+49 −2
Merged

exit with usage when need login to image registry #8225

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
131eb2a
exit with usage when need login to github
medyagh May 20, 2020
e2eade2
remove debugging
medyagh May 20, 2020
493b35b
remove debugging statements
medyagh May 20, 2020
489495d
resolve review comments
medyagh May 21, 2020
dcbcecd
remnove debugging
medyagh May 21, 2020
2c0719e
fix spelling
medyagh May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove debugging
@medyagh
medyagh committed May 20, 2020

Verified

This commit was signed with the committer’s verified signature.
medyagh Medya Ghazizadeh
GPG key ID: 7CF7792C6DF3245C
Verified
Learn about vigilant mode
commit e2eade2aaf1982d0cd60fc11c223621a1c109795
2 changes: 1 addition & 1 deletion pkg/drivers/kic/types.go
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ const (

var (
// BaseImage is the base image is used to spin up kic containers. it uses same base-image as kind.
BaseImage = fmt.Sprintf("gcr.io/k8s-minikube/kicbase1:%s@sha256:%s", Version, baseImageSHA)
BaseImage = fmt.Sprintf("gcr.io/k8s-minikube/kicbase:%s@sha256:%s", Version, baseImageSHA)
// BaseImageFallBack the fall back of BaseImage in case gcr.io is not available. stored in github packages https://github.com/kubernetes/minikube/packages/206071
// github packages docker does _NOT_ support pulling by sha as mentioned in the docs:
// https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-docker-for-use-with-github-packages