-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Cilium to version 1.12.3 #15242
Conversation
|
Welcome @rastaman! |
Hi @rastaman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rastaman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 54.5s 54.0s 55.7s 55.6s 56.7s Times for minikube (PR 15242) ingress: 28.3s 29.2s 28.7s 28.8s 28.2s docker driver with docker runtime |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
I will look at the tests results. |
@rastaman thank you for this PR ! look forward for more contributions from you |
Context
The Cilium version deployed by minikube is quite old and doesn't support
arm64
setups.This PR update Cilium to version 1.12.3.
Implementation
Update Kubernetes template in
minikube/pkg/cni/cilium.go
to:Tests
This has been tested by running current minikube code from a Mac M1 with the podman driver in a Qemu VM (limavm) runnning Fedora Core 36 (
Fedora-Cloud-Base-36-1.5.aarch64
):