Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated image in helm addon #12377

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Aug 30, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh changed the title fix depricated image in helm addon fix depericated image in helm addon Aug 30, 2021
@medyagh
Copy link
Member Author

medyagh commented Aug 30, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 30, 2021
@spowelljr spowelljr changed the title fix depericated image in helm addon fix deprecated image in helm addon Aug 30, 2021
@medyagh
Copy link
Member Author

medyagh commented Aug 31, 2021

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12377) |
+----------------+----------+---------------------+
| minikube start | 53.1s    | 51.6s               |
| enable ingress | 33.4s    | 33.0s               |
+----------------+----------+---------------------+

Times for minikube start: 51.6s 52.5s 55.0s 53.9s 52.5s
Times for minikube (PR 12377) start: 54.2s 50.3s 53.2s 49.5s 50.9s

Times for minikube ingress: 32.9s 34.9s 32.0s 33.4s 33.9s
Times for minikube (PR 12377) ingress: 32.4s 32.9s 33.4s 33.4s 32.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12377) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.4s               |
| enable ingress | 32.5s    | 35.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 35.5s 37.0s 28.5s 26.5s 35.0s
Times for minikube (PR 12377) ingress: 35.0s 35.5s 34.5s 36.0s 35.0s

Times for minikube start: 23.2s 22.8s 23.0s 22.4s 22.1s
Times for minikube (PR 12377) start: 21.9s 22.0s 22.2s 22.9s 23.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12377) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 44.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 27.7s 44.8s 44.1s 44.7s 44.9s
Times for minikube (PR 12377) start: 44.2s 45.5s 44.7s 44.7s 44.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 1.72 (chart)
Docker_Linux_crio TestNetworkPlugins/group/bridge/DNS (gopogh) 5.96 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 6.73 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/BuildImage (gopogh) 6.90 (chart)
KVM_Linux TestFunctional/parallel/SaveImage (gopogh) 7.02 (chart)
Docker_Linux TestStartStop/group/no-preload/serial/Pause (gopogh) 7.33 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 10.45 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 11.21 (chart)
Docker_Windows TestAddons/parallel/GCPAuth (gopogh) 15.94 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 19.49 (chart)
Docker_Windows TestFunctional/parallel/LoadImageFromFile (gopogh) 20.00 (chart)
Docker_Windows TestScheduledStopWindows (gopogh) 20.74 (chart)
Hyperkit_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 21.19 (chart)
Docker_Linux_crio TestStartStop/group/embed-certs/serial/Stop (gopogh) 27.81 (chart)
Docker_Linux_crio TestStartStop/group/no-preload/serial/Pause (gopogh) 29.82 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 33.33 (chart)
Docker_Linux_containerd_arm64 TestNetworkPlugins/group/kindnet/Start (gopogh) 38.85 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 39.26 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/GCPAuth (gopogh) 42.76 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/auto/Start (gopogh) 48.84 (chart)
Docker_Linux_crio TestScheduledStopUnix (gopogh) 49.01 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/SaveImageToFile (gopogh) 50.88 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/CSI (gopogh) 51.03 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/MountCmd/any-port (gopogh) 53.96 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/SaveImage (gopogh) 54.39 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 55.56 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 57.64 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 57.93 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 58.87 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/PersistentVolumeClaim (gopogh) 59.31 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 769ee32 into kubernetes:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestAddons/parallel/HelmTiller: image pull permission problem
4 participants