Fix instanceID for vmss nodes

[feiskyer]

What this PR does / why we need it:

When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong.

Their providerID should be in format azure:///subscriptions/<subscription-id>/resourceGroups/<rg-name>/providers/Microsoft.Compute/virtualMachineScaleSets/<scaleset-name>/virtualMachines/<instance-id>.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59855

Special notes for your reviewer:

Release note:

Fix instanceID for vmss nodes.

[feiskyer]

/cc @andyzhangx

[feiskyer]

/retest

[jhorwit2]

@feiskyer FYI, you can't update the provider id once it has been set. I imagine that's going to be a problem for existing nodes with the incorrect provider id?

[feiskyer]

@feiskyer FYI, you can't update the provider id once it has been set. I imagine that's going to be a problem for existing nodes with the incorrect provider id?

@jhorwit2 Yep, but please note that vmss is not included in any releases yet. It is a feature for 1.10.

[jberkus]

reminder: it is now Code Slush. This PR needs status/approved-for-milestone in order to merge. Thanks.

[feiskyer]

ping @andyzhangx

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cloudprovider/providers/azure/OWNERS [andyzhangx,feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

/retest

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.