-
Notifications
You must be signed in to change notification settings - Fork 53
Update to latest version of kubeflow/common #47
Conversation
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
There's some breaking changes actually. I think somehow it uses old version in the build. https://github.com/kubeflow/common readme has updated API names. https://github.com/kubeflow/tf-operator/pull/1152/files has some package name changes, not not exact same project since xgboost not only use api but also implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: merlintang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
There have been good amount of enhancements in kubeflow/common but no interface change yet so here we only update the
go.sum
file.Signed-off-by: terrytangyuan terrytangyuan@gmail.com