Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

Update to latest version of kubeflow/common #47

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

terrytangyuan
Copy link
Member

There have been good amount of enhancements in kubeflow/common but no interface change yet so here we only update the go.sum file.

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@kubeflow-bot
Copy link

This change is Reviewable

@Jeffwan
Copy link
Member

Jeffwan commented Apr 16, 2020

@terrytangyuan

There's some breaking changes actually. I think somehow it uses old version in the build.

https://github.com/kubeflow/common readme has updated API names.

https://github.com/kubeflow/tf-operator/pull/1152/files has some package name changes, not not exact same project since xgboost not only use api but also implementation

Copy link
Contributor

@merlintang merlintang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@merlintang
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: merlintang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab64f65 into kubeflow:master Apr 16, 2020
@terrytangyuan terrytangyuan deleted the update-common branch April 16, 2020 14:07
@terrytangyuan
Copy link
Member Author

@Jeffwan Looks like the problem is that we have Gopkg.* files in the repo. I am deleting them in #48 and revert the update of kubeflow/common. We can update later when kubeflow/common is more stable.

xfate123 pushed a commit to xfate123/xgboost-operator that referenced this pull request May 16, 2020
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants