Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(backend): Remove deprecated v2 compatibility mode docs #10956

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

droctothorpe
Copy link
Contributor

Description of your changes:
This PR just removes some deprecated documentation from the backend/src/v2 README file.

Checklist:

@google-oss-prow google-oss-prow bot requested review from chensun and Tomcli June 25, 2024 17:04
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
@droctothorpe
Copy link
Contributor Author

@droctothorpe can you sign off your commits?

Fixed. Sorry about that!

Copy link

@droctothorpe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 6ffd2b9 link false /test kubeflow-pipelines-samples-v2
kubeflow-pipeline-upgrade-test 6ffd2b9 link false /test kubeflow-pipeline-upgrade-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 26, 2024
@google-oss-prow google-oss-prow bot merged commit 1b5de64 into kubeflow:master Jun 26, 2024
6 of 8 checks passed
@droctothorpe droctothorpe deleted the docs branch June 26, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants