-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): use kfp.dsl.types to replace kfp.components.types Fixes #10282 #10283
fix(sdk): use kfp.dsl.types to replace kfp.components.types Fixes #10282 #10283
Conversation
Fixes: kubeflow#10282 Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
Hi @hsinhoyeh. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, @hsinhoyeh. Thank you for proposing the change. However, deprecated is currently not part of the KFP 2.x.x public API. It's used only for testing the KFP backend. |
@connor-mccarthy Thanks for the reply. That make sense to me totally. But I am wondering if the deprecated api is still there (in the part of the sdk), should we at least guarantee it is functional working? right now the deprecated API is not working except for some doc string points in the wrong direction :( |
I see what you're saying, though I think the break is representative of the reason we don't plan to guarantee the code's functionality; we don't plan to backward compatibly support this code with each change to the rest of SDK. The reference docs cover what is considered to be a part of the public API. If you need the objects in the deprecated namespace, we recommend using the KFP SDK v1 directly. |
Reopening. While we don't endorse use of deprecated in the general case, we can check in this PR to unblock you and fix the tests. /ok-to-test |
@hsinhoyeh: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Test failures are independent of these changes. Manually merging. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you! |
…eflow#10282 (kubeflow#10283) * use kfp.dsl.types to replace kfp.components.types Fixes: kubeflow#10282 Signed-off-by: hsinhoyeh <yhh92u@gmail.com> * fix import artifact_types --------- Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
Fixes: #10282
Description of your changes:
replacing
kfp.components.types
withkfp.dsl.types
as the package is relocated.Checklist: