Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): use kfp.dsl.types to replace kfp.components.types Fixes #10282 #10283

Merged

Conversation

hsinhoyeh
Copy link
Contributor

Fixes: #10282

Description of your changes:

replacing kfp.components.types with kfp.dsl.types as the package is relocated.

Checklist:

Fixes: kubeflow#10282
Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
Copy link

Hi @hsinhoyeh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@connor-mccarthy
Copy link
Member

Hi, @hsinhoyeh. Thank you for proposing the change. However, deprecated is currently not part of the KFP 2.x.x public API. It's used only for testing the KFP backend.

@hsinhoyeh
Copy link
Contributor Author

Hi, @hsinhoyeh. Thank you for proposing the change. However, deprecated is currently not part of the KFP 2.x.x public API. It's used only for testing the KFP backend.

@connor-mccarthy Thanks for the reply. That make sense to me totally. But I am wondering if the deprecated api is still there (in the part of the sdk), should we at least guarantee it is functional working? right now the deprecated API is not working except for some doc string points in the wrong direction :(

@connor-mccarthy
Copy link
Member

connor-mccarthy commented Dec 4, 2023

I see what you're saying, though I think the break is representative of the reason we don't plan to guarantee the code's functionality; we don't plan to backward compatibly support this code with each change to the rest of SDK. The reference docs cover what is considered to be a part of the public API.

If you need the objects in the deprecated namespace, we recommend using the KFP SDK v1 directly.

@connor-mccarthy
Copy link
Member

Reopening. While we don't endorse use of deprecated in the general case, we can check in this PR to unblock you and fix the tests.

/ok-to-test

Copy link

@hsinhoyeh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 02ea38d link false /test kubeflow-pipelines-samples-v2
kubeflow-pipelines-sdk-execution-tests 02ea38d link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member

Test failures are independent of these changes. Manually merging.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member

Thank you!

@connor-mccarthy connor-mccarthy merged commit b40912c into kubeflow:master Dec 13, 2023
1 check passed
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
…eflow#10282 (kubeflow#10283)

* use kfp.dsl.types to replace kfp.components.types

Fixes: kubeflow#10282
Signed-off-by: hsinhoyeh <yhh92u@gmail.com>

* fix import artifact_types

---------

Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] no module named `kfp.components.types' error when a deprecated package is used.
2 participants