Skip to content
This repository was archived by the owner on Jun 22, 2021. It is now read-only.

feat: Adds support for loading new results. #13

Merged
merged 2 commits into from
Mar 28, 2018
Merged

feat: Adds support for loading new results. #13

merged 2 commits into from
Mar 28, 2018

Conversation

ryasmi
Copy link
Member

@ryasmi ryasmi commented Mar 28, 2018

In previous versions it hasn't been possible to repeatedly send requests with a previous cursor to fetch any new results. This pull request makes it possible by returning the send cursor when no results are available and adding two new properties to the Result of getEntities called hasMoreForward and hasMoreBackward.

ADDS: createCursorsFromEntities util for use in createGetEntitiesResult.

BREAKING CHANGE: Removes PaginationFilterError.
BREAKING CHANGE: Removes createEndCursorResult.
BREAKING CHANGE: Changes createCursorFromEntity params.
BREAKING CHANGE: Changes createGetEntitiesResult return value.
BREAKING CHANGE: Removes end from Cursor.
BREAKING CHANGE: Changes the return type in the signature of getEntities.
BREAKING CHANGE: Renames previousCursor to backwardCursor in getEntities result.
BREAKING CHANGE: Renames nextCursor to forwardCursor in getEntities result.

@ryasmi ryasmi self-assigned this Mar 28, 2018
@ryasmi ryasmi merged commit e9e670a into master Mar 28, 2018
@ryasmi ryasmi deleted the fix-cursors branch March 28, 2018 12:17
@HT2Bot
Copy link
Member

HT2Bot commented Mar 28, 2018

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants