Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct luacheck URL in doc/lua-filters.md #10589

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Correct luacheck URL in doc/lua-filters.md #10589

merged 1 commit into from
Jan 31, 2025

Conversation

rnwst
Copy link
Contributor

@rnwst rnwst commented Jan 31, 2025

See #10568. I used the wrong luacheck URL in my earlier PR. Sorry about that!

@@ -399,7 +399,7 @@ colon syntax (`mystring:uc_upper()`).
# Debugging Lua filters

Many errors can be avoided by performing static analysis.
[`luacheck`](https://github.com/rnwst/pandoc.git) may be used for this
[`luacheck`](https://github.com/mpeterv/luacheck) may be used for this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is also incorrect. The old maintainer passed away several years ago (see the top issue in that repository) and nobody has access to it. This is the canonical repository now:

Suggested change
[`luacheck`](https://github.com/mpeterv/luacheck) may be used for this
[`luacheck`](https://github.com/lunarmadules/luacheck) may be used for this

Copy link
Contributor

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the actual canonical repo. You can confirm by looking at the luarocks.org entry and issue history.

@rnwst
Copy link
Contributor Author

rnwst commented Jan 31, 2025

Thanks @alerque for pointing this out. Btw, there is a typo in your URL :) I force-pushed just now, hopefully it's correct now!

@jgm jgm merged commit 77fca2d into jgm:main Jan 31, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants