Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #12806 - UriCompliance listener reporting updates #12807

Open
wants to merge 3 commits into
base: jetty-12.0.x
Choose a base branch
from
Open

Issue #12806 - UriCompliance listener reporting updates #12807

wants to merge 3 commits into from

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Feb 19, 2025

  • Make reporting of detected UriCompliance violations in HttpURI always occur.
  • But only trigger a BadMessageException if the UriCompliance doesn't allow for that violation.
  • Also update javadoc on TRUNCATED_UTF8_ENCODING to indicate that it will never be reported as itself.

Fixes #12806

@joakime joakime added the Bug For general bugs on Jetty side label Feb 19, 2025
@joakime joakime requested a review from gregw February 19, 2025 17:52
@joakime joakime self-assigned this Feb 19, 2025
@dudaerich
Copy link

dudaerich commented Feb 20, 2025 •
edited
Loading

The same issue is in HttpCompliance, RFC6265CookieParser, CookieCutter, HttpParser and maybe on other places.

@joakime
Copy link
Contributor Author

joakime commented Feb 21, 2025

Postponing to 12.0.18

@joakime joakime added the Sponsored This issue affects a user with a commercial support agreement label Feb 26, 2025
@gregw
Copy link
Contributor

gregw commented Mar 3, 2025

@joakime Should this be draft until all the implementations are updated? Do you need any help on this?

gregw
gregw requested changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently has conflicts. request my review again when they are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
Jetty 12.0.18
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to migrate from legacy compliance mode
3 participants
@joakime @dudaerich @gregw