Replace duplicated glyphs with References and Fix carons #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This is really a great improvement. It made it possible for me to fix all the wrong carons in no time 🚀 See also which is a PR against this PR 😬 Related: |
|
This looks great. Can you include instructions about the build script in the README? (Just a "this is an option to build the font"). Once @Finii PR is merged into this one we can merge everything into master. |
[why] The carons are all upside down and look like a small circumflex. The dcaron and tcaron use a caron instead of an apothrophe. [how] - Flip caron glyph - Add combining-comma-above-right (shortened version from comma) - Recreate dcaron and tcaron from d/t and that new glyph - Increase version number (patchlevel by one) - Mention Rodrigo in copyright. See also ryanoasis/nerd-fonts#1492 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Rodrigodd
changed the title
|
@jesusmgg all done. Notice that the build of the new version of the font was not committed in this PR. If you want me to include it already built, let me know. |
|
@jesusmgg Been a while since this PR was ready. Is there anything else that needs to be done before merging this? |
|
Thank you @jesusmgg 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking today into adding accents to ampersand's Comic Sans, but I thankfully found out about this fork before committing any work to it.
But while examining this font and comparing it to the original Comic Sans, I noticed that many of the accented glyphs could benefit from references (as Comic Sans does) instead of copying the vector data (as it currently does). To fix this, I just had to run "Edit -> Replace with Reference" in FontForge on all glyphs, and it fixed it automatically. I didn't extensively revised everything, but I didn't find any error caused by it or obviously missed opportunities.
I have zero experience in font editing, so I am not sure if there are any drawbacks to it, but it already decreased the size of the TTF font by 56% (the OTF stayed the same size), and it should help with maintainability.
I also included a script for generating the fonts from source that I made while figuring out how to build the font. But I can remove it if you think it is not necessary.
I didn't update the font files because I don't know if you prefer to update them only at version releases to avoid increasing the repository size.