-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(images): add support for Core Lightning v23.08.2, v24.02.2 & v24.05 #879
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 141 141
Lines 4609 4663 +54
Branches 897 902 +5
=========================================
+ Hits 4609 4663 +54 ☔ View full report in Codecov by Sentry. |
I'm going to hold off on merging this until right before shipping the next release. The removal of older CLN nodes from nodes.json would break existing Polar users that could apply the out-of-band node version updates. |
Awesome! I would like to help test building the CLN Docker images. Please let me know how I can best help test. |
Hey @toneloc, the images have already been built and pushed to Docker Hub. The instructions for how I build the images are in the docker readme. If you want to test them out in Polar, you'll need to be running the the code in this PR branch because the new images won't work in v2.2.0. You'll need to setup your dev environment to run Polar from source code. The instructions are in the CONTRIBUTING doc. Just be sure to checkout this branch. |
Awesome thanks. FYI, I had to remove - After that I was able to start up a Polar network with two v24.02.2 CLN nodes and create a channel and send payments back and forth. All via UI. If you want me to test anything in particular please lmk. Will let you know if I see anything else notable. Nice work. Next I want to try to create custom Docker image so I can add in a CLN plugin. Any tips on that please lmk. |
@toneloc Thanks so much for testing and confirming it works for you. That is very helpful.
What version of NodeJS are you running? I've seen issues related to this flag when you aren't running v20.
Getting your plugin into the docker image should be pretty easy. This is how Polar currently installs the polar/docker/clightning/Dockerfile Lines 170 to 183 in 927459e
You'd just need to get your plugin's files into the image via
|
Oh interesting. From looking at the code involved in that stacktrace, I suspect that this error is not the root cause, but a result of the chart links object being undefined, which shouldn't be possible. Is this the first error displayed in the logs immediately after opening a channel? Would you mind sharing logs?
|
Look like on restart the line showed up! Then I created a channel and it is working now. Not sure what happened. FYI: Polar logs: And front end: The Polar logs look okay. The front end logs may show you something! I'll let you known as I play around. |
I can also confirm that it works with the new CLN versions. Didn't encounter any issues so far. 👍 |
@michaelWuensch Thanks for the feedback. 👍 |
4875f6a
to
44a3bc0
Compare
Hi @jamaljsr and thanks for this awesome features. Any idea when this will be merged ? Otherwise, how to use this version of Polar even before the release? Currently struggling a lot to run CLN 24.02 with |
Hi @darioAnongba, I'm planning on packaging up a release sometime next week. I'm trying to wait for a few of the currently open PRs to get merged. If you'd like to locally package a build of Polar with the changes from this PR, I mentioned how to do this in #879 (comment). |
thanks! I'll try to run it on my own with your comment. Edit: just letting you know that this PR no longer compiles because the version of the package I'll better wait patiently. |
Can you also add CLN 24.05 with the upcoming release? |
@michaelWuensch I added support for v24.05 here as well. |
dc88a5f
to
e0b692f
Compare
Can this be merged? :) |
Actually I built this branch myself and i am getting these errors for cln and lnd and can't get the containers to start.
|
@niteshbalusu11 What OS and docker version are you running. I tested on Mac, Windows, and Linux and didn't have any issues. |
It's only happening with latest versions of LND and CLN btw. MacOS Arm chips
|
Ok, I'm running on an ARM Mac. Those are filesystem errors you're getting. My hunch is that Docker is misbehaving. Try restarting Docker and/or your computer. That will likely resolve the issue. |
Ok looks like it was docker misbehaving. Seems to be working fine now. Thank you! |
The embedded CLN REST API supports WebSocket connections, so we can remove the currently implemented polling logic with subscribing to the WebSocket events.
Closes #772
Replaces #774
Description
Adds support for Core Lightning v23.08.2 & v24.02.2.
I've migrated to using the Core Lightning embedded REST API plugin
clnrest
from previously using the third-party c-lightning-REST plugin. Since older versions of CLN do not support theclnrest-port
flag, I have dropped support in Polar for versions prior to these two.Screenshots