Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --tlsextradomain=host.docker.internal to lnd default args #761

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

SeverinAlexB
Copy link
Contributor

@SeverinAlexB SeverinAlexB commented Aug 15, 2023

Hi Hi!

I am working on a one-click docker-compose setup for Blocktank, our open-source Synonym LSP solution. The goal is to make it work seamlessly with Polar so one can test and develop Blocktank without any issues.
To make it as seamless as possible, an additional LND default argument is required.

Description

This PR adds --tlsextradomain=host.docker.internal to the LND default arguments. host.docker.internal is a special domain name in docker that resolves to the IP address of the host system. This allows other docker containers (not in the same docker network) to connect to the LND GRPC port exposed to the host machine.

Without this argument, LND TLS will reject the GRPC connection due to the unknown domain name.

At the moment, Blocktank users need to

  1. Add this extra argument in "Advanced Options".
  2. Open Terminal and delete the existing TLS certificate.
  3. Restart the container to regenerate the cert.

I tried to programatically add this argument to the networks.json but Polar doesn't like changes in networks.json while it's running.

Adding this as default argument, solves this cumbersome problem. I am sure other apps using Polar will appreciate this change as well.

Thanks for having a look. Let me know if you need something else changed in this PR.

Copy link
Owner

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR

@jamaljsr jamaljsr merged commit d6e6fef into jamaljsr:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants