Add --tlsextradomain=host.docker.internal to lnd default args #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Hi!
I am working on a one-click docker-compose setup for Blocktank, our open-source Synonym LSP solution. The goal is to make it work seamlessly with Polar so one can test and develop Blocktank without any issues.
To make it as seamless as possible, an additional LND default argument is required.
Description
This PR adds
--tlsextradomain=host.docker.internalto the LND default arguments. host.docker.internal is a special domain name in docker that resolves to the IP address of the host system. This allows other docker containers (not in the same docker network) to connect to the LND GRPC port exposed to the host machine.Without this argument, LND TLS will reject the GRPC connection due to the unknown domain name.
At the moment, Blocktank users need to
I tried to programatically add this argument to the networks.json but Polar doesn't like changes in networks.json while it's running.
Adding this as default argument, solves this cumbersome problem. I am sure other apps using Polar will appreciate this change as well.
Thanks for having a look. Let me know if you need something else changed in this PR.