-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mining): automatically mine new blocks #707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking over this PR.
I tested it and the functionality works as expected. This seems pretty much done. I just left a couple of minor tweaks.
It looks like the unit tests are failing. Would you mind taking a look at them. |
Yes, I'll see if I can fix them |
Fixed the tests and added some new unit tests for the automine. |
c696ebb
to
46c09c2
Compare
I will still edit the tests a bit to get the coverage to 100 so CI passes fully. |
Sorry, didn't run the full CI before the last commit. Now it should be ok. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #707 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 116 118 +2
Lines 3437 3528 +91
Branches 647 634 -13
=========================================
+ Hits 3437 3528 +91
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work on the tests! Thanks for completing this feature. So happy to see this added.
Closes #566
Based on the code of @zackypick
Continues the unmerged PR #613
Description
Added auto mine dropdown button with several options (Off, every 30s, every 1m / 5m / 10m)
Button includes embedded progress bar (time left to mine)
Steps to Test