-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(general bugs): workflow fixes #685
Conversation
-taro nodes connect in order when dropped into the graph -Taro info asset draw title says 'No Assets' if there are no assets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Info sidebar, I could have been more specific. The problem I see with this is having a divider with no content below it looks weird. So I was thinking to add text below the divider stating "This node does not have any assets.", so there is content below it.
It looks like code coverage for the network.ts
file dropped with this update.
Thanks for that clarity. Sorry for missing that code coverage. Ill update this asap. |
I haven't seen this before, I have 100% line coverage, why would statements and functions be less than 100? |
Most likely you have an |
Super interesting how a nuanced a language can be. Looks like a sorted array apparently wont sort if it doesn't need to. Pretty cool optimization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 👍
This looks good now. Just one small nitpick.
Renamped Styled.P to Styled.Empty
-taro nodes connect in order when dropped into the graph -Taro info asset draw title says 'No Assets' if there are no assets --------- Co-authored-by: Andrew Oseen <amovfx@protonmail.com>
-taro nodes connect in order when dropped into the graph -Taro info asset draw title says 'No Assets' if there are no assets --------- Co-authored-by: Andrew Oseen <amovfx@protonmail.com>
-taro nodes connect in order when dropped into the graph -Taro info asset draw title says 'No Assets' if there are no assets --------- Co-authored-by: Andrew Oseen <amovfx@protonmail.com>
-taro nodes connect in order when dropped into the graph
-Taro info asset draw title says 'No Assets' if there are no assets