-
Notifications
You must be signed in to change notification settings - Fork 13.5k
bug: logLevel enum is not exported #30255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Issue number: resolves #30255 --------- ## What is the current behavior? `LogLevel` is not properly exported ## What is the new behavior? Exports `LogLevel` in core ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Dev build: `8.5.4-dev.11743715474.1eadbd25` Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
Thank you @brandyscarney for the resolution! 🙏 However, there's a small issue with the way LogLevel is exported in @ionic/core. It's currently declared as a According to the TypeScript documentation, For example, the following code will fail to compile: import { IonicConfig, LogLevel } from '@ionic/core';
export const ionicConfig: IonicConfig = {
logLevel: LogLevel.ERROR, // ❌ Error: Cannot access ambient const enums when 'isolatedModules' is enabled
}; Would it be possible to switch LogLevel to a regular enum instead of a const enum in the package? Thanks again |
Thank you for letting me know @5im0n! Could you test out this dev build and let me know if you see any other issues? |
🎉 @brandyscarney Thank you for the update! I tested the dev build |
@5im0n Thanks for the quick reply! Version |
Prerequisites
Ionic Framework Version
v8.x
Current Behavior
The release of Ionic 8.5.0 introduced the
logLevel
option inIonicConfig
.However, the
LogLevel
enum is not exported by the@ionic/core
module.As a result, we are unable to use
LogLevel.OFF
(or any other value from LogLevel) when defining the logLevel property inIonicConfig
.We can't configure it
Expected Behavior
The
LogLevel
enum should be properly exported by@ionic/core
, allowing developers to set the logLevel inIonicConfig
without any import issues.Steps to Reproduce
@ionic/core
version 8.5.0.@ionic/core
in a TypeScript file.LogLevel.OFF
inside IonicConfig.Code Reproduction URL
https://stackblitz.com/edit/ykhte9q1?file=src%2Fmain.ts
Ionic Info
Ionic:
Ionic CLI : 7.2.0
Utility:
cordova-res : not installed globally
native-run : not installed globally
System:
NodeJS : v20.18.3
npm : 11.1.0
OS : Windows 10
Additional Information
No response
The text was updated successfully, but these errors were encountered: