-
Notifications
You must be signed in to change notification settings - Fork 13.5k
bug: (vue) router-link
has wrong type since 8.4.5/8.5.0
#30254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's also in 8.4.4 |
Thank you for the issue. 🙂 Could you try out this dev build and let me know if you're seeing any other issues:
|
While I see the string type has been added, there are other values that can be passed that work for Types accepted by Thanks again |
Thank you @mattschlosser! Here is a new dev build: |
That build fixes the issue. Thanks |
Issue number: resolves #30254 --------- ## What is the current behavior? The type for `routerLink` was incorrectly set as `symbol`. ## What is the new behavior? The new update of the Vue output target to sets it to `string | symbol` ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information Dev build: `8.5.1-dev.11742238707.15ce0fe2` --------- Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
Issue number: resolves #30254 --------- The type for `routerLink` was incorrectly set as `symbol`. The new update of the Vue output target to sets it to `string | symbol` - [ ] Yes - [x] No Dev build: `8.5.1-dev.11742238707.15ce0fe2` --------- Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
v8.x
Current Behavior
router-link
has the wrong type since 8.4.5. When attempting to build, the build fails with error TS2322Expected Behavior
vue-tsc produces no errors
Steps to Reproduce
router-link
prop as described in the docsnpm run build
Code Reproduction URL
https://github.com/mattschlosser/ionic-vue-ts-demo/tree/router-link
Ionic Info
Ionic:
Ionic CLI : 7.2.0 (C:\Users\...\AppData\Roaming\npm\node_modules@ionic\cli)
Ionic Framework : @ionic/vue 8.5.0
Capacitor:
Capacitor CLI : 7.0.1
@capacitor/android : not installed
@capacitor/core : 7.0.1
@capacitor/ios : not installed
Utility:
cordova-res : not installed globally
native-run : 2.0.1
System:
NodeJS : v22.14.0 (C:\Program Files\nodejs\node.exe)
npm : 10.9.2
OS : Windows 10
Additional Information
#30221
The text was updated successfully, but these errors were encountered: