Skip to content

bug:(vue) Required props for IonNav component in 8.4.3 #30179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
Ericlm opened this issue Feb 5, 2025 · 2 comments · Fixed by stenciljs/output-targets#630 or #30239
Closed
3 tasks done

bug:(vue) Required props for IonNav component in 8.4.3 #30179

Ericlm opened this issue Feb 5, 2025 · 2 comments · Fixed by stenciljs/output-targets#630 or #30239
Labels

Comments

@Ericlm
Copy link
Contributor

Ericlm commented Feb 5, 2025

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

When adding an IonNav component in a Vue component, some props that was not required before 8.4.3 became required, and make the type-check fail.

before :

import type { VNode } from "vue";
export declare const IonNav: import("vue").DefineComponent<unknown, () => VNode<import("vue").RendererNode, import("vue").RendererElement, {
    [key: string]: any;
}>, {}, import("vue").ComputedOptions, import("vue").MethodOptions, import("vue").ComponentOptionsMixin, import("vue").ComponentOptionsMixin, {}, string, import("vue").VNodeProps & import("vue").AllowedComponentProps & import("vue").ComponentCustomProps, Readonly<unknown>, {}>;

After :

export declare const IonNav: import("vue").DefineSetupFnComponent<{
    animated: boolean;
    animation: Function;
    root: any;
    rootParams: any;
    swipeGesture: boolean;
}, {}, {}, {
    animated: boolean;
    animation: Function;
    root: any;
    rootParams: any;
    swipeGesture: boolean;
} & {}, import("vue").PublicProps>;

Expected Behavior

The required props should be the same as before 8.4.3

Steps to Reproduce

  1. Create a Ionic + Vue project
  2. Add an IonNav component
  3. Type errors appear to add some required props

Code Reproduction URL

https://github.com/Ericlm/vue-ion-nav

Ionic Info

Ionic:

   Ionic CLI       : 7.2.0 (/Users/ericlemaitre/.asdf/installs/nodejs/22.13.0/lib/node_modules/@ionic/cli)
   Ionic Framework : @ionic/vue 8.4.3

Capacitor:

   Capacitor CLI      : 7.0.1
   @capacitor/android : not installed
   @capacitor/core    : 7.0.1
   @capacitor/ios     : not installed

Utility:

   cordova-res : not installed globally
   native-run  : 2.0.1

System:

   NodeJS : v22.13.0 (/Users/ericlemaitre/.asdf/installs/nodejs/22.13.0/bin/node)
   npm    : 10.9.2
   OS     : macOS Unknown

Additional Information

No response

@brandyscarney
Copy link
Member

Thank you for the issue! We're currently investigating this, along with all other related Vue issues introduced in version 8.4.3.

github-merge-queue bot pushed a commit that referenced this issue Mar 13, 2025
Issue number: fixes #30179

---------

## What is the current behavior?
There have been issues reported on version 8.4.3 related to the type
information changing for Vue

## What is the new behavior?

This patch updates the Vue components to be correctly types using a new
version of the output target.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No
Copy link

ionitron-bot bot commented Apr 10, 2025

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants