Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the dependencies #53

Closed
dmahajan980 opened this issue Jan 15, 2020 · 4 comments · Fixed by #62
Closed

Update the dependencies #53

dmahajan980 opened this issue Jan 15, 2020 · 4 comments · Fixed by #62
Assignees
@dmahajan980

Comments

@dmahajan980
Copy link

dmahajan980 commented Jan 15, 2020 •
edited
Loading

It seems that the dependencies have not been updated for a long time and it may be better if we stick to the latest versions. For the record, I've attached the screenshot of the dependencies which can be updated.
upd
@AdrianBZG
Copy link
Member

Hi @dmahajan980 ,

Thanks for spotting that, it looks that dependencies are quite old now 😟 , would you like to pick up this issue?

@AdrianBZG
Copy link
Member

PS: Some of the dependencies have been now updated by #52, but some others might still be outdated.

@dmahajan980
Copy link
Author

I think, I could update the dependencies one by one while going through the code base. So @AdrianBZG please assign it to me.

@dmahajan980
Copy link
Author

dmahajan980 commented Jan 15, 2020 •
edited
Loading

@AdrianBZG I am getting a lot of errors while running the project locally.
err1
err2
I'm not sure about it but do you think that some of the above could possibly be due to some error in #52?

@dmahajan980 dmahajan980 mentioned this issue Feb 6, 2020
Merged
AdrianBZG pushed a commit that referenced this issue Sep 3, 2020
@JM-Mendez
Improve DX by strongly typing the project (#53)
09850d1 
Improve DX by strongly typing the project

Squashed commits:
* Add typescript definitions so intellisense can pick them up

* Remove @ts-ignore comments

* Use typescript to typescheck source files

* Send global events to all machines

* Type up query controller machine state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmahajan980 dmahajan980

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the dependencies and removed unnecessary packages dmahajan980/InterMine-Data-Browser-Tool
2 participants
@AdrianBZG @dmahajan980