Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements [Feature Request] CustomPaint for drawPath #31 #32

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Implements [Feature Request] CustomPaint for drawPath #31 #32

merged 4 commits into from
Aug 10, 2023

Conversation

sikandernoori
Copy link
Contributor

fixes #31

@sikandernoori
Copy link
Contributor Author

@ikbendewilliam can you please check this PR.

@ikbendewilliam
Copy link
Collaborator

Thank you for your PR!
Code looks good, can you add a description in the readme for the argument? The same one as you've written in the code is good

@sikandernoori
Copy link
Contributor Author

Thank you for your PR! Code looks good, can you add a description in the readme for the argument? The same one as you've written in the code is good

Done.

ikbendewilliam
ikbendewilliam previously approved these changes Aug 10, 2023
View reviewed changes
@ikbendewilliam
Copy link
Collaborator

Your formatting seems to have failed. Please run dart format . (might also be my mistake in a previous push, but if you run this it should be fixed)

@sikandernoori
Copy link
Contributor Author

Your formatting seems to have failed. Please run dart format . (might also be my mistake in a previous push, but if you run this it should be fixed)

Done.

@ikbendewilliam
Copy link
Collaborator

Ah so it was my bad. Apologies

@ikbendewilliam ikbendewilliam merged commit 4b9140b into icapps:main Aug 10, 2023
@ikbendewilliam
Copy link
Collaborator

Release in progress. New version is 0.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikbendewilliam ikbendewilliam ikbendewilliam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] CustomPaint for drawPath
2 participants
@sikandernoori @ikbendewilliam