Interval and threshold specific for a trigger #92
+108
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iberianpig
reviewed
Aug 14, 2018
spec/lib/config_spec.rb
Outdated
|
|
||
| context 'when threshold is set on the trigger' do | ||
| before do | ||
| allow(YAML).to receive(:load_file).and_return keymap_with_trigger_threshold |
There was a problem hiding this comment.
[RuboCop]
Metrics/LineLength: Line is too long. [85/80]
iberianpig
reviewed
Aug 14, 2018
spec/lib/config_spec.rb
Outdated
| { | ||
| 'swipe' => { | ||
| 4 => { | ||
| 'right' => { |
There was a problem hiding this comment.
[RuboCop]
Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
iberianpig
reviewed
Aug 14, 2018
spec/lib/config_spec.rb
Outdated
|
|
||
| context 'when interval is set on the trigger' do | ||
| before do | ||
| allow(YAML).to receive(:load_file).and_return keymap_with_trigger_interval |
There was a problem hiding this comment.
[RuboCop]
Metrics/LineLength: Line is too long. [84/80]
iberianpig
reviewed
Aug 14, 2018
spec/lib/config_spec.rb
Outdated
| 'right' => { | ||
| 'shortcut' => 'alt+Right', | ||
| 'interval' => 0.3 | ||
| }, |
There was a problem hiding this comment.
[RuboCop]
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
iberianpig
reviewed
Aug 14, 2018
spec/lib/config_spec.rb
Outdated
| 'left' => { | ||
| 'shortcut' => 'alt+Left', | ||
| 'threshold' => 0.8 | ||
| }, |
There was a problem hiding this comment.
[RuboCop]
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
|
Perfect! 💯 BTW, I will add pinch rotation to fusuma. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to use this project for controlling the volume on my computer with a 3 finger swipe, so I added the possibility to add a custom interval and threshold for a trigger.
With this code I can setup my config like below and it will be possible to smoothly control the volume on the touchpad.
Let me know what you think. I don't have any experience with Ruby, but I hope it looks good.