Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Country search should not be case sensitive #466

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix: Country search should not be case sensitive #466

merged 1 commit into from
May 24, 2024

Conversation

AmitGurbani
Copy link
Contributor

@AmitGurbani AmitGurbani commented May 23, 2024 •
edited
Loading

Issue
Country search doesn't work for input containing capital letters (INDIA, inDIa).

Steps to reproduce

  1. Enable dropdown options with showSearchBox: true
  2. Type INDIA and check dropdown options
  3. Type inDIa and check dropdown options
    image

Proposed solution
Convert user input to lowercase before filtering the countries list

After the fix
image

@AmitGurbani
Copy link
Contributor Author

@iamstevendao , Is it possible to prioritise on this issue/PR?

@iamstevendao
Copy link
Owner

thanks @AmitGurbani

@iamstevendao iamstevendao merged commit 95a111b into iamstevendao:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamstevendao iamstevendao iamstevendao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmitGurbani @iamstevendao