feature: rewrite to Composition API #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniil4udo wow! that's huge & looks promising. thanks for your help! |
|
Did for the template. Not sure I can do it inside the script tag. also made tests work + added extra |
|
@daniil4udo that's awesome! thanks a heap! |
|
@daniil4udo there are some errors when I try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's a lot of changes... I didn't change any logic, just an attempt to add typings and Composition API
defineModelgetDefaultmoved to theutils.ts- there's an important limitation to keep in mind: defineProps() (and similar functions like defineEmits() or useSlots()) cannot reference locally declared variables within the same <script setup> block. This limitation arises because these API calls are hoisted outside of the setup function by the Vue compiler during the SFC compilation process. Hoisting means that these calls are moved to the top of the module scope, so they execute before any local variables are defined, thus they cannot reference those variables.