1. 去掉sortMode的默认排序mode #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@io/github/iamazy/elasticsearch/dsl/sql/parser/QueryOrderByParser.java:37 2. 使得Or 或 and 语句支持右表达式 使用in语句 @io/github/iamazy/elasticsearch/dsl/sql/parser/query/exact/BinaryQueryParser.java:138 3. 添加无参toDsl, toPrettyDsl @io.github.iamazy.elasticsearch.dsl.sql.model.ElasticSqlParseResult.toDsl()
iamazy
reviewed
Dec 23, 2021
| @@ -266,6 +266,9 @@ private boolean binaryContextMatch(ElasticsearchParser.ExpressionContext express | |||
| if (expressionContext instanceof ElasticsearchParser.NameExprContext) { | |||
| return true; | |||
| } | |||
| if (expressionContext instanceof ElasticsearchParser.InContext) { | |||
There was a problem hiding this comment.
FixedHistoryTest.fixedOn20211221 添加了测试用例
|
好
***@***.***
发件人： iamazy
发送时间： 2021-12-23 15:12
收件人： iamazy/elasticsearch-sql
抄送： Cenck; Author
主题： Re: [iamazy/elasticsearch-sql] 1. 去掉sortMode的默认排序mode (PR #66)
@iamazy commented on this pull request.
In elasticsearch-sql-core/src/main/java/io/github/iamazy/elasticsearch/dsl/sql/parser/query/exact/BinaryQueryParser.java:
@@ -266,6 +266,9 @@ private boolean binaryContextMatch(ElasticsearchParser.ExpressionContext express
if (expressionContext instanceof ElasticsearchParser.NameExprContext) {
return true;
}
+ if (expressionContext instanceof ElasticsearchParser.InContext) {
可以添加个测试用例吗
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@io/github/iamazy/elasticsearch/dsl/sql/parser/query/exact/BinaryQueryParser.java:138
@io.github.iamazy.elasticsearch.dsl.sql.model.ElasticSqlParseResult.toDsl()