-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first commit #1
base: master
Are you sure you want to change the base?
first commit #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
при переходе на страницу таймер отображается не сразу и высота контейнера зависит от его наличия.
поправь верстку, чтобы соответствовала макету (шрифты, отступы и тд);
нужно, чтобы роутинг был без хэшей #;
при обновлении неверно отображается активная страница;
при переходе между страницами с помощью кнопок назад/вперед в браузере, не изменяется подсветка активной страницы;
Исправишь - тегни меня здесь
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
дублируешь иконки
можно экспортировать все иконки из фигмы
используй svg формат, он легче
@@ -0,0 +1,228 @@ | |||
const mapPage = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
интересный подход, но мб вынести html к html? в js файлах оставить только js
|
||
hours = (hours < 10) ? "0" + hours : hours; | ||
minutes = (minutes < 10) ? "0" + minutes : minutes; | ||
seconds = (seconds < 10) ? "0" + seconds : seconds; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно как-нибудь избежать дублирования?)
} | ||
|
||
function initializeMap() { | ||
setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
зачем тут setTimeout
?
navigateTo('/timer'); | ||
}); | ||
|
||
document.querySelectorAll('nav ul li').forEach(function(item) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
выше везде писал через () => {
выбери один подход
@@ -0,0 +1,15 @@ | |||
.container, .row{ | |||
max-width: 760px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
задавай размеры за счет margin/padding + у тебя же адаптив должен быть
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
еще я не могу понять откуда ты берешь иконки?))
экспортируй из фигмы
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно просто использовать теги <link>
и <script>
(см. доку bootstrap)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тут тоже просто <link>
и <script>
<i class="fas fa-camera me-1"></i> <span>Photos</span> | ||
</div> | ||
<div class="icon-text-group"> | ||
<i class="fas fa-cog me-1"></i> <span></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
зачем пустой span
?
No description provided.