Skip to content

Modularize instruct_pix2pix SD inferencing during and after training in examples #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Conversation

satani99
Copy link
Contributor

@satani99 satani99 commented Apr 8, 2024

What does this PR do?

Part of #6545

Before submitting

Who can review?

@sayakpaul

@satani99
Copy link
Contributor Author

satani99 commented Apr 8, 2024

hey @sayakpaul can you review this pr

@yiyixuxu yiyixuxu requested a review from sayakpaul April 8, 2024 17:54
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
Copy link
Member

Can we fix the code quality tests first?

@satani99 satani99 closed this Apr 9, 2024
@satani99 satani99 deleted the pix2pix branch April 9, 2024 02:01
@satani99 satani99 restored the pix2pix branch April 9, 2024 02:01
@satani99 satani99 reopened this Apr 9, 2024
@satani99
Copy link
Contributor Author

satani99 commented Apr 9, 2024

@sayakpaul

@sayakpaul
Copy link
Member

The code quality still isn't passing. Is this instruction not helpful for you?

https://github.com/huggingface/diffusers/actions/runs/8625336763/job/23641773402?pr=7603#step:6:1

@sayakpaul
Copy link
Member

Will give the PR time to run and then merge.

@sayakpaul sayakpaul merged commit 37e9d69 into huggingface:main Apr 10, 2024
8 checks passed
@satani99 satani99 deleted the pix2pix branch April 10, 2024 05:51
sayakpaul added a commit that referenced this pull request Dec 23, 2024
…in examples (#7603)

* Modularize instruct_pix2pix code

* quality check

* quality check

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants