Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Make it clearer where you are logging in to #17459

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

When logging in to the instance you visit:
CleanShot 2023-08-02 at 14 08 20

When authorising something external (like https://cast.home-assistant.io/):
CleanShot 2023-08-02 at 14 07 36

When authorising the companion apps:
IMG_53CFA4D1B321-1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit ac20cf2 into dev Aug 8, 2023
@bramkragten bramkragten deleted the auth-flow-client-id branch August 8, 2023 12:43
@piitaya piitaya mentioned this pull request Sep 25, 2023
8 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants