Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut path input improvements #3831

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

jpelgrom
Copy link
Member

Summary

I noticed that when editing a shortcut, it was relatively easy to enter incorrect data. This PR updates the keyboard + handling of shortcut to hopefully prevent input errors.

Screenshots

No app UI changes but the on screen keyboard should now be optimized for URI entry.

For example Gboard shows a / key for me instead of ,:
On screen keyboard with a / key in the bottom left where there would normally be a , key

Link to pull request in Documentation repository

n/a

Any other notes

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement! I always forget about the keyboard options that help us in these cases :)

@JBassett JBassett merged commit b6687dc into home-assistant:master Aug 31, 2023
@jpelgrom jpelgrom deleted the shortcut-path-improve branch September 1, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants