fix: Rust highlights (regression from the reverse-query-precedence PR) #12795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really a fan of the constant highlight for |
Ok, then I'll remove it from Haskell as well for consistency |
nik-rev
force-pushed
the
fix-rust-highlights
branch
from
8906683 to
65d74ee
Compare
the-mikedavis
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
I tested this for a while yesterday and I think it looks good, I haven't run into any other (fixable) regressions yet. There are still some issues with attributes:
I looked into that for a while though and I don't think it's an easy fix - the bug is in the highlighter rather than the queries. It will be fixed when we switch to the new highlighter (#10286) anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some minor things as well as regressions from the query precedence PR
Regressions
Derive Regression
Before
Regression
Enum Regression
Before
Regression
Prelude Regression
Fixed by moving the prelude later to give it higher priority over other queries
Before
Regression
Constructor Regression
Fixed by moving the constructor queries after the PascalCase identifiers to give it higher priority
Before
Regression
Fixes
Incorrect angle bracket color
Before
After
!not an operator hereBefore
After
Angled For brackets
Before
After