Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary allocations in switch_case #12786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m4rch3n1ng
Copy link

previously it would allocate a Vec for every single char it would try to switch_case for, even when the case did not actually change, which is not necessary.

@nik-rev
Copy link
Contributor

nik-rev commented Feb 5, 2025

why even use flat_map? why not to_ascii_lowercase which returns char so we can just do a map

edit: oh, i understand that it's not guaranteed that we always have ASCII chars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants