Skip to content

fixed hie.yaml.stack #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2020
Merged

fixed hie.yaml.stack #664

merged 2 commits into from
Dec 11, 2020

Conversation

tittoassini
Copy link
Contributor

I am submitting this hoping that someone more knowledgable than me will have a long look at it.

Changes:

  • fixed some incorrect component name (e.g. hls-hlint-plugin:lib:hls-hlint-plugin)

  • added entries for recently added plugins

  • ordered components alphabetically

  • all targets reported by 'stack ide targets' are now covered, except for:

ghcide:exe:ghcide-bench
ghcide:exe:ghcide-test-preprocessor
ghcide:test:ghcide-tests
ghcide:bench:benchHist
hie-compat:lib

Doubts/Notes:

  • Coverage is not comprehensive, haskell-language-server still returns a lot of 'Files that failed"

  • What is this for?

  • path: "./.stack-work/"
    component: "haskell-language-server:lib"
  • What is this for?

    • path: "./exe/Arguments.hs"
      component: "haskell-language-server:exe:haskell-language-server"

    as ./exe/Arguments.hs does not exist

  • Isn't it inconsistent to mark test/testdata as 'none' here and then have it its own hie.yaml? This leads to a lot of Failed files

@jneira
Copy link
Member

jneira commented Dec 10, 2020

I am submitting this hoping that someone more knowledgable than me will have a long look at it.

Changes:

* fixed some incorrect component name (e.g. hls-hlint-plugin:lib:hls-hlint-plugin)

* added entries for recently added plugins

* ordered components alphabetically

* all targets reported by 'stack ide targets' are now covered, except for:

ghcide:exe:ghcide-bench
ghcide:exe:ghcide-test-preprocessor
ghcide:test:ghcide-tests
ghcide:bench:benchHist
hie-compat:lib

Thanks a lot, we had that file a little bit abandoned

Doubts/Notes:

* Coverage is not comprehensive, haskell-language-server still returns a lot of 'Files that failed"

Assumed, although it makes harder use it to trace problems. Maybe we should fix it so it would worth to open an issue about

* What is this for?
* path: "./.stack-work/"
  component: "haskell-language-server:lib"

To load Path_${moduleName}.hs with stack versions prior to 2.5.1. I think we could remove it, as it is noted in the troubleshooting section of the readme.

* What is this for?
  
  * path: "./exe/Arguments.hs"
    component: "haskell-language-server:exe:haskell-language-server"
  
  as ./exe/Arguments.hs does not exist

That module was moved to the lib so it is not longer needed

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sync the config file, stack users will thank this

@jneira jneira merged commit 9a742e2 into haskell:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants