Skip to content

Make hlint plugin buildable with ghc 9.8 #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make hlint plugin buildable with ghc 9.8 #3997

wants to merge 1 commit into from

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Jan 20, 2024

hlint 3.8 with support for ghc 9.8 was released to hackage today.

michaelpj
michaelpj approved these changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the plugin support table

@michaelpj
Copy link
Collaborator

Also the test workflow

@michaelpj
Copy link
Collaborator

Actually if you don't mind I'm fixing a couple of other issues like this and I might roll this change into it!

@michaelpj
Copy link
Collaborator

#3998

I had to do a little bit of test wrangling also

@jhrcek
Copy link
Collaborator Author

jhrcek commented Jan 21, 2024 •
edited
Loading

Thanks for picking that up, closing as superseded by #3998

@jhrcek jhrcek closed this Jan 21, 2024
@jhrcek jhrcek deleted the jhrcek/hlint-buildable-with-9.8 branch January 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhrcek @michaelpj