Skip to content

Remove HsLogger #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Remove HsLogger #3526

merged 2 commits into from
Mar 18, 2023

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Mar 15, 2023

Building on top of #3524

Last dependency on hslogger is in implicit-hie-cradle which seemingly doesn't use it, see Avi-D-coder/implicit-hie-cradle#14

@fendor fendor force-pushed the enhance/no-more-hslogger branch 2 times, most recently from 9825a4e to 464f9ec Compare March 17, 2023 15:09
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray

@michaelpj
Copy link
Collaborator

Genuine failure with -Werror due to a missing import.

@fendor fendor force-pushed the enhance/no-more-hslogger branch from 464f9ec to d89186b Compare March 18, 2023 11:31
@fendor fendor force-pushed the enhance/no-more-hslogger branch from d89186b to 33822d6 Compare March 18, 2023 11:57
@fendor fendor added the merge me Label to trigger pull request merge label Mar 18, 2023
@mergify mergify bot merged commit 014c8f9 into haskell:master Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants