Skip to content

Fix lower ghcide bounds of rename and fourmolu plugins #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

pepeiborra
Copy link
Collaborator

These plugins depend on the usePropertyAction api that was introduced first in ghcide 1.9

@pepeiborra
Copy link
Collaborator Author

I have published Hackage revisions already

Copy link
Collaborator

@georgefst georgefst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Feb 24, 2023
@mergify mergify bot merged commit 50799fe into master Feb 24, 2023
@georgefst
Copy link
Collaborator

Not that it really matters, but it just occurred to me that I thought I'd already fixed this in #3443. Perhaps I was misinformed about the version of ghcide in which usePropertyAction was added? Or maybe the problem is that that PR didn't have a corresponding Hackage revision.

wz1000 pushed a commit that referenced this pull request Mar 14, 2023
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants