Skip to content

Add Wingman support for GHC 9.2 #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

santiweight
Copy link
Collaborator

@santiweight santiweight commented Dec 5, 2022

Implements steps 3 & 4 of the plan outlined in #2971 (comment).

The first commit "Implement Sandy's simplify-wingman changes" implements step 3 by squashing the changes Sandy wrote in https://github.com/haskell/haskell-language-server/compare/wingman-to-new-plugin. (I couldn't find a way to get non-crap merge conflicts, so I just did a checkout instead).

The rest of the commits implement 9.2 support.

  • Clean up code
  • (optional) Fix around 4 tests that have formatting problems
  • Remove tests that we will no longer support/mark them as failing
  • CPP the ghcide stuff

@santiweight santiweight force-pushed the wingman-ghc-9.2 branch 4 times, most recently from 31b8ae4 to 38c0403 Compare December 5, 2022 08:04
@subterfugue
Copy link

What's the progress on this? Anything that needs to be done?

@re-xyr
Copy link

re-xyr commented Feb 15, 2023

Hi, what's the progress of this PR? Is it still worked on?

@kintrix007
Copy link

Hey, seems like great work, but did this get abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants