Fix ghc source plugins for GHC 9.2 #3311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is supposed to fix ghc source plugins for GHC 9.4 as well, but I couldn't prove that locally. After GHC 9.0, plugins no longer live in DynFlags, but in HscEnv. Thus, we need to make sure to pass the modified HscEnv to the subsequent typechecking and renaming phase.
pepeiborra
approved these changes
Nov 1, 2022
| @@ -172,18 +172,18 @@ typecheckModule :: IdeDefer | |||
| typecheckModule (IdeDefer defer) hsc tc_helpers pm = do | |||
| let modSummary = pm_mod_summary pm | |||
| dflags = ms_hspp_opts modSummary | |||
| mmodSummary' <- catchSrcErrors (hsc_dflags hsc) "typecheck (initialize plugins)" | |||
| (mmodSummary') <- catchSrcErrors (hsc_dflags hsc) "typecheck (initialize plugins)" | |||
There was a problem hiding this comment.
Suggested change
| (mmodSummary') <- catchSrcErrors (hsc_dflags hsc) "typecheck (initialize plugins)" | |
| mmodSummary' <- catchSrcErrors (hsc_dflags hsc) "typecheck (initialize plugins)" |
|
Indeed, I did not see it! Closing this in favour of #3309 |
|
I'm dying to have this fix and that other PR is stalled. Any chance you can merge this one? |
|
@m4dc4p In the meantime you can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to fix ghc source plugins for GHC 9.4 as well, but I couldn't prove that locally.
After GHC 9.0, plugins no longer live in DynFlags, but in HscEnv. Thus, we need to make sure to pass the modified HscEnv to the subsequent typechecking phase.
Supposed to fix #2989, let's see whether it works out.
This is likely to have been introduced by #2128 (my bad!)
EDIT:
I am going to write a regression test for thisJust needed to enable the test.