You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some other place that inserts imports too, right?
I'm only aware of code action and completion. Both of them use the same function to determine the insert position. I'll try to look for more, but if anyone knows, please comment here.
Previously we fixed the functions that extend import lists to use ghc-exactprint, and this PR fixes the functions that insert new import declarations. So It think we are good now
I searched for [a-zA-Z0-9]import and import[a-zA-Z0-9] case-insensitively in the project. Some plugins have import-related stuff, but it seems that they are not adding new imports.
* haskell#2414 fix new import position
* fix auto import for ghc version < 9.2
* re-fix it for ghc-9.2
* handle comments
* add more comments
* reword comments of findPositionNoImports
Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kokobd
force-pushed
the
2414-fix-import-pos
branch
from
This will close #2414
Progress: