Fix hanging redundant import on Unicode function #2870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a low-level `is_ident` that only works on ascii characters. Instead match directly on the '_' character. The original functionality has been restored (using `isAlpha` instead). This commit removes the now unneccessary `is_ident` compat layer
drsooch
force-pushed
the
fix-unicode-redundant-imports
branch
from
6179208 to
528a8bd
Compare
pepeiborra
approved these changes
Apr 30, 2022
I think that it makes sense to add a simple test based on the repro I reported in #2859 to make sure that the reported issue is actually solved by this PR. |
|
Will add one yes |
|
Regression test properly fails. Will timeout after some time, hope this is reasonable? |
michaelpj
approved these changes
Apr 30, 2022
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
May 21, 2022
* Revert partial changes from haskell#2483 Instead of using a low-level `is_ident` that only works on ascii characters. Instead match directly on the '_' character. The original functionality has been restored (using `isAlpha` instead). This commit removes the now unneccessary `is_ident` compat layer * Add regression test for unicode functions Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* Revert partial changes from haskell#2483 Instead of using a low-level `is_ident` that only works on ascii characters. Instead match directly on the '_' character. The original functionality has been restored (using `isAlpha` instead). This commit removes the now unneccessary `is_ident` compat layer * Add regression test for unicode functions Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2859
Revert partial changes from #2483
For redundant import actions, the code path ends up calling
wrapOperatorInParenwhich under the hood makes a call tois_identwhich is a low-levelChar -> Bool. The function will panic when it's input falls out of ASCII range.The fix is just to match directly on the '_' character. Outside of this codepath, the original
functionality has been restored (using
isAlpha).Also removes the now unnecessary
is_identcompat layer.