-
-
Notifications
You must be signed in to change notification settings - Fork 389
Prepare 1.6.1.1 (only hackage release) #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jneira
commented
Feb 2, 2022
•
edited by gitpod-io
bot
Loading
edited by gitpod-io
bot
- We will use the fourth position for this release cause it will not have a github/gitlab/ghcup release, only a hackage one
- It tries to fix the build workflow, broken since Add the -dynamic flag and update build instructions #2668 (see https://github.com/haskell/haskell-language-server/actions/runs/1779913965)
- I think the cause has been mix the dynamic build in the test workflow and the static one in the build one
- The cabal store restored from the cache, populated by test/caching workflow makes the static build fail
- The solution is moving the flag setting to the generic action used for all workflows
- This will be backported to the 1.6.1.1-hackage branch, created on the 1.6.1.0 one
@Mergifyio backport 1.6.1.1-hackage |
🟠 Waiting for conditions to match
|
@@ -63,6 +63,10 @@ runs: | |||
fi | |||
shell: bash | |||
|
|||
# The default build for haskell-language-server executable is dynamic for linux and macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you.
I changed the title of the troubleshooting section, breaking the url of the th warning. |
…anguage-server into prepare-1.6.1.1
Maybe it should just link to the documentation root and then say in prose where to look? e.g. "Check the documentation, look for BLAH in the troubleshooting section" |
* Disable -dynamic for all workflows * Remove quotes * Bump version to 1.6.1.1 * Update changelog for 1.6.1.1 * Correct flag set * add comment to ci step * Restore header and link (cherry picked from commit 9d75cc5) # Conflicts: # ChangeLog.md
✅ Backports have been created
|
buy it would be longer and less direct... a more specific and dedicated URL + redirection in docs would serve as the needed indirection, rtd allows those things? |
I wonder if markdown lets you change the header but use a custom anchor, to keep the previous anchor |
* Prepare 1.6.1.1 (only hackage release) (#2681) * Disable -dynamic for all workflows * Remove quotes * Bump version to 1.6.1.1 * Update changelog for 1.6.1.1 * Correct flag set * add comment to ci step * Restore header and link (cherry picked from commit 9d75cc5) # Conflicts: # ChangeLog.md * Fix merge conflict Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>