Make work stack-9.2.1.yaml and enable pedantic (-WError) for cabal

[jneira]

• Going deeper underground:

1. Make stack build work for ghc-9.2.1
2. It turns out that it has enable pedantic for the hls packahe so i had to fix somewarnins in func-test
3. I remembered @michaelpj and me talked about make consistent the use of the flag
4. Enable the flag for the default cabal build
5. Fix a good bunch of warning everywhere 😆 , several of them in tactics

[jneira]

stack build does not work anymore, since https://app.circleci.com/pipelines/github/jneira/haskell-language-server/1506/workflows/bf168e6e-0c8e-4784-95a1-c98d555c5358/jobs/12418 😢

[jneira]

I am trying to fix the build release workflow here and i am afraid we have a new dependency which needs integer-gmp. As we are building the binaries for linux with alpine where some ghcs are using integer-simple, the build fails:

Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] trying: ghcide-1.5.0.1 (user goal)
[__1] trying: lsp-types-1.4.0.0 (dependency of ghcide)
[__2] trying: mod-0.1.2.2 (dependency of lsp-types)
[__3] next goal: integer-gmp (dependency of mod)
[__3] rejecting: integer-gmp-1.0.3.0, integer-gmp-1.0.2.0,
integer-gmp-1.0.1.0, integer-gmp-1.0.0.1, integer-gmp-1.0.0.0,
integer-gmp-0.5.1.0 (only already installed instances can be used)
[__3] fail (backjumping, conflict set: integer-gmp, mod)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: base, ghcide, integer-gmp, lsp-types,
mod

afaics mod has no flag to switch to integer-simple like we are doing for blaze-textual

//cc @michaelpj @Bodigrim

[michaelpj]

I suggest we leave the integer-simple issue for another PR since this is getting big.

[michaelpj]

This will rebuild everything, I think? do we want that? seems like it'll make the workflow slow. Maybe it's okay.

[jneira]

only local packages (as --flags only affect them), even the ones without the flag as we have one package in the root of the local dependency tree with the flag available

[jneira]

I suggest we leave the integer-simple issue for another PR since this is getting big.

yeah i've already accumulated too many things here

[jneira]

@michaelpj it is the pr ok to merge (ignoring fo now the release build failure)?