Skip to content

hls-explicit-imports-plugin: Add golden files to hackage tarball #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2021
Merged

hls-explicit-imports-plugin: Add golden files to hackage tarball #2373

merged 1 commit into from
Nov 20, 2021

Conversation

maralorn
Copy link
Contributor

No description provided.

jneira
jneira approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh good catch, wondering why the hackage workflow didn't fail, will take a look

@jneira jneira merged commit 81673c5 into haskell:master Nov 20, 2021
@jneira
Copy link
Member

jneira commented Nov 20, 2021

ugh good catch, wondering why the hackage workflow didn't fail, will take a look

simply the reason is the workflow does not run tests so we dont catch packaging issues 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maralorn @jneira